Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add access control to service level #698

Merged
merged 4 commits into from
Sep 26, 2024
Merged

add access control to service level #698

merged 4 commits into from
Sep 26, 2024

Conversation

FilipMasar
Copy link
Collaborator

@FilipMasar FilipMasar commented Sep 24, 2024 •
edited
Loading

Changes proposed in this PR:

  • add credentials field in Service
  • check service credentials in download task
  • return http status 403 if credentials deny access - on both service and asset level
  • tests
    • unit tests were already implemented here
    • new integration test
    • new util file with ganachePrivateKeys to better understand from where some random strings comes from

Notes

@FilipMasar FilipMasar mentioned this pull request Sep 24, 2024
Merged
@FilipMasar FilipMasar mentioned this pull request Sep 24, 2024
Merged
paulo-ocean
paulo-ocean approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bogdanfazakas
bogdanfazakas approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit c5799f9 into main Sep 26, 2024
12 checks passed
@alexcos20 alexcos20 deleted the feature/credentials-on-service-level branch September 26, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinbica valentinbica valentinbica left review comments

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FilipMasar @alexcos20 @valentinbica @bogdanfazakas @paulo-ocean