Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add credentials to service type #1855

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

FilipMasar
Copy link
Collaborator

@FilipMasar FilipMasar commented Sep 24, 2024

related to this PR in ocean-node oceanprotocol/ocean-node#698

Changes proposed in this PR:

  • add credentials field in Service

Open questions

  • Is there something else that has to be updated?

Copy link

codeclimate bot commented Sep 24, 2024

Code Climate has analyzed commit 6cdf695 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FilipMasar FilipMasar merged commit fdfe741 into main Oct 1, 2024
11 checks passed
@FilipMasar FilipMasar deleted the feature/credentials-on-service-level branch October 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants