Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Converted the PerformanceHome to function component. #7799

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

Eezi
Copy link
Collaborator

@Eezi Eezi commented Oct 20, 2024

No description provided.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://refactorclass-components-to-functio.opencrvs.dev

Copy link
Collaborator

@Siyasanga Siyasanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eezi thanks for the changes, everything looks good except for one error I saw in the UserReviewForm. I left a comment on it

@Eezi
Copy link
Collaborator Author

Eezi commented Nov 2, 2024

Thanks for reviewing the code!

Copy link
Collaborator

@Siyasanga Siyasanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@Siyasanga
Copy link
Collaborator

@Eezi I'm happy with the changes, please feel free to merge using the squash and merge strategy when you are ready

@Siyasanga
Copy link
Collaborator

@rikukissa do you if the changes from this PR are going to go into a specific milestone?

@rikukissa
Copy link
Member

@Siyasanga No, just directly to develop is fine 👍

@Eezi Eezi merged commit 375df64 into develop Nov 4, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants