-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Converted the PerformanceHome to function component. #7799
Conversation
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
Your environment is deployed to https://refactorclass-components-to-functio.opencrvs.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eezi thanks for the changes, everything looks good except for one error I saw in the UserReviewForm. I left a comment on it
packages/client/src/views/SysAdmin/Team/user/userCreation/UserReviewForm.tsx
Show resolved
Hide resolved
Thanks for reviewing the code! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM!
@Eezi I'm happy with the changes, please feel free to merge using the |
@rikukissa do you if the changes from this PR are going to go into a specific milestone? |
@Siyasanga No, just directly to develop is fine 👍 |
No description provided.