Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Converted the PerformanceHome to function component. #7799

Merged
merged 8 commits into from
Nov 4, 2024
Merged

refactor: Converted the PerformanceHome to function component. #7799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc334cd
refactor: Converted the PerformanceHome to function component.
Eezi Oct 20, 2024
4d5a4c1
Merge branch 'develop' into refactor/class-components-to-function
Eezi Oct 27, 2024
67ba1bb
Merge branch 'develop' into refactor/class-components-to-function
rikukissa Oct 28, 2024
2001a00
Merge branch 'develop' into refactor/class-components-to-function
Eezi Oct 29, 2024
64dbd94
refactor: refactored the LoadingIndicatorComp component to functional.
Eezi Oct 29, 2024
4257517
refactor: refactored the UserReviewFormComponent component to functio…
Eezi Oct 29, 2024
169c74f
fix: Added missing prop
Eezi Oct 31, 2024
bf8a461
Merge branch 'develop' into refactor/class-components-to-function
Eezi Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions packages/client/src/views/OfficeHome/LoadingIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,36 +74,36 @@ type IBaseLoadingProps = {

type IProps = IBaseLoadingProps & IntlShapeProps & IOnlineStatusProps

class LoadingIndicatorComp extends React.Component<IProps> {
render() {
const { loading, noDeclaration, hasError, intl } = this.props

return (
<Wrapper>
{this.props.isOnline && loading && (
<LoadingContainer>
<Spinner id="Spinner" size={24} baseColor="#4C68C1" />
</LoadingContainer>
)}
<MobileViewContainer noDeclaration={noDeclaration}>
{this.props.isOnline && hasError && (
<ErrorText id="search-result-error-text-count">
{intl.formatMessage(errorMessages.queryError)}
</ErrorText>
)}
{!this.props.isOnline && (
<ConnectivityContainer>
<NoConnectivity />
<Text id="wait-connection-text">
{intl.formatMessage(constantsMessages.noConnection)}
</Text>
</ConnectivityContainer>
)}
</MobileViewContainer>
</Wrapper>
)
}
}
const LoadingIndicatorComp = ({
loading,
noDeclaration,
hasError,
intl,
isOnline
}: IProps) => (
<Wrapper>
{isOnline && loading && (
<LoadingContainer>
<Spinner id="Spinner" size={24} baseColor="#4C68C1" />
</LoadingContainer>
)}
<MobileViewContainer noDeclaration={noDeclaration}>
{isOnline && hasError && (
<ErrorText id="search-result-error-text-count">
{intl.formatMessage(errorMessages.queryError)}
</ErrorText>
)}
{!isOnline && (
<ConnectivityContainer>
<NoConnectivity />
<Text id="wait-connection-text">
{intl.formatMessage(constantsMessages.noConnection)}
</Text>
</ConnectivityContainer>
)}
</MobileViewContainer>
</Wrapper>
)

export function withOnlineStatus<T>(
WrappedComponent: React.ComponentType<T & IOnlineStatusProps>
Expand Down
Loading
Loading