TRT-1834: initial version of openshift-tests-extension #2
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
stbenjam
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@stbenjam: This pull request references TRT-1834 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Want to clean up commit history before we merge anything |
openshift-ci
bot
added
the
do-not-merge/hold
| Name string `json:"name"` | ||
| Lifecycle Lifecycle `json:"lifecycle"` | ||
| Duration int64 `json:"duration"` | ||
| StartTime *time.Time `json:"startTime"` |
There was a problem hiding this comment.
Should we marshal into a format bigquery can ingest directly without parsing; e.g. 2020-06-02 23:57:12.120174 UTC. In the ultimate aggregated format output from origin, I think we would want it in the directly ingestible format. Changing between timezones and date formats between run-tests and the aggregated format could confuse end-users.
There was a problem hiding this comment.
Hopefully I did this right, it matches your format:
{
"name": "[sig-testing] openshift-tests-extension should support passing tests",
"lifecycle": "blocking",
"duration": 1,
"startTime": "2024-10-02 17:33:50.089649 UTC",
"endTime": "2024-10-02 17:33:50.091001 UTC",
"result": "passed",
"output": "",
"error": "",
"details": null
},
stbenjam
force-pushed
the
example
branch
2 times, most recently
from
685e661 to
ddd291f
Compare
stbenjam
changed the title
Vendoring the deps since our openshift golang image wants it.
|
/lgtm |
|
/hold cancel |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Initial implementation of openshift/enhancements#1676.
Requires enhancements to our forked ginkgo openshift/onsi-ginkgo#15