-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static routes to netConfig to support scenario A #782
base: main
Are you sure you want to change the base?
Add static routes to netConfig to support scenario A #782
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adopting a workload using scenario A (different subnet ranges between wallaby CP and next-gen CP) wont succeed if netConfig doesn't have the routes to reach old CP. Relates: OSPRH-7544
24b9574
to
ff083d1
Compare
@averdagu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/96f987176e814792beedcd98d60c7eb5 ✔️ noop SUCCESS in 0s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7642f2ffde2146fbafd30cc22d1231a0 ✔️ noop SUCCESS in 0s |
@@ -24,6 +24,9 @@ netconfig_networks: | |||
start: 172.17.0.100 | |||
cidr: 172.17.0.0/24 | |||
vlan: 20 | |||
routes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need to change defaults? should we apply this only for the envs where we need to modify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that this won't affect on the default scenario, as this route is already added by system (since the interface belongs already to 172.17.0.0/24) and I didn't want to overengineer it). But I could modify it to only modify it in case it's the scenario A (though this may need some extra variable from install_yamls)
Adopting a workload using scenario A (different subnet ranges between wallaby CP and next-gen CP) wont succeed if netConfig doesn't have the routes to reach old CP.
Relates: OSPRH-7544