Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static routes to netConfig to support scenario A #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add static routes to netConfig to support scenario A #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/roles/dataplane_adoption/defaults/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ netconfig_networks:
start: 172.17.0.100
cidr: 172.17.0.0/24
vlan: 20
routes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to change defaults? should we apply this only for the envs where we need to modify it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that this won't affect on the default scenario, as this route is already added by system (since the interface belongs already to 172.17.0.0/24) and I didn't want to overengineer it). But I could modify it to only modify it in case it's the scenario A (though this may need some extra variable from install_yamls)

- destination: 172.17.1.0/24
nexthop: 172.17.0.100
- name: External
dnsDomain: external.example.com
subnets:
Expand Down Expand Up @@ -60,6 +63,9 @@ netconfig_networks:
start: 172.19.0.100
cidr: 172.19.0.0/24
vlan: 22
routes:
- destination: 172.19.1.0/24
nexthop: 172.19.0.100
registry_name: "quay.io"
registry_namespace: "podified-antelope-centos9"
image_tag: "current-podified"
Expand Down
Loading