-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add util to build tripolar grid #228
Conversation
254e9f4
to
1b9dd99
Compare
@huard @aulemahal this implements the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest making bipolar_projection
and generate_bipolar_cap_mesh
private functions.
Co-authored-by: David Huard <[email protected]>
for more information, see https://pre-commit.ci
@aulemahal friendly reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have much knowledge of tripolar grids, but this code looks fine!
PR #223 uses data files that are too big, this PR adds code to build a simple (simplistic?) tripolar grid for testing purposes only. PR #223 could then use this function to generate its own tests with synthetic data from a tripolar grid to a regular grid using some type of field (e.g. sin(lat) )