Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve processing core from official source #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mingness
Copy link
Collaborator

@mingness mingness commented Dec 4, 2024

Retire use of micycle1's repo, and point to official maven source.
remove previous repository dependencies.

@mingness mingness requested a review from Stefterv December 4, 2024 13:08
Copy link

github-actions bot commented Dec 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://processing.github.io/processing-library-template/pr-preview/pr-63/
on branch gh-pages at 2024-12-04 13:09 UTC


// these two are needed to resolve processing4 from micycle1's repo
maven { url = uri("https://jitpack.io") }
maven { url = uri("https://jogamp.org/deployment/maven/") }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jogamp should still be in there for jogl no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I tried to build it without, and it worked. I deleted the build and release folders beforehand for good measure - do I need to delete something on my file system to check more robustly? There is nothing related to jogl in my ~/.m2 folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, well it doesn't hurt to leave it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add it back in, but I also want to understand the situation well. It doesn't hurt, but as far as I can tell, it doesn't help? I guess, it would be needed if we ever wanted to run Processing from the template? I verified that the build requires the jogamp repository if resolving Processing with micycle1's repo, but if resolving from processing.org, the jogamp repo is not necessary.

build.gradle.kts Show resolved Hide resolved
@mingness mingness requested a review from Stefterv December 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants