Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve processing core from official source #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

resolve processing core from official source #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,13 @@ if(currentOS.isMacOsX) {
// You can add additional repositories here if your dependencies are hosted elsewhere.
repositories {
mavenCentral()

// these two are needed to resolve processing4 from micycle1's repo
maven { url = uri("https://jitpack.io") }
maven { url = uri("https://jogamp.org/deployment/maven/") }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jogamp should still be in there for jogl no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I tried to build it without, and it worked. I deleted the build and release folders beforehand for good measure - do I need to delete something on my file system to check more robustly? There is nothing related to jogl in my ~/.m2 folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, well it doesn't hurt to leave it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add it back in, but I also want to understand the situation well. It doesn't hurt, but as far as I can tell, it doesn't help? I guess, it would be needed if we ever wanted to run Processing from the template? I verified that the build requires the jogamp repository if resolving Processing with micycle1's repo, but if resolving from processing.org, the jogamp repo is not necessary.

}

// Add any external dependencies your library requires here.
// The provided example uses Apache Commons Math. Replace or add as needed.
dependencies {
// resolve Processing core
compileOnly(group = "com.github.micycle1", name = "processing-core-4", version = "4.3.1")
// We are currently resolving from an unofficial, jitpack-enabled, processing4 repository.
// Eventually, this will change to an official source.
compileOnly(group = "org.processing", name = "core", version = "4.3.1")
mingness marked this conversation as resolved.
Show resolved Hide resolved

// insert your external dependencies
implementation(group = "org.apache.commons", name = "commons-math3", version = "3.6.1")
Expand Down
Loading