Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #100

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Various improvements #100

merged 4 commits into from
Jan 10, 2025

Conversation

Korijn
Copy link
Contributor

@Korijn Korijn commented Jan 10, 2025 •
edited
Loading

  • Rename matrix inversion method "manual" to "python"
  • Reduce a few more matrix allocations
  • Add option to mat_inverse to raise an error if the matrix is not invertible. The default remains returning all zeros.
  • Add option to vec_unproject to skip matrix inversion.
  • Reuse mat_inverse in vec_unproject.
  • Bump version

@Korijn Korijn requested a review from almarklein January 10, 2025 10:12
almarklein
almarklein approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Korijn Korijn merged commit ce18542 into main Jan 10, 2025
10 checks passed
@Korijn Korijn deleted the various-improvements branch January 10, 2025 12:05
This was referenced Jan 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almarklein almarklein almarklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Korijn @almarklein