Split loading and generating ECC private key c'tors #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All ECC schemes provided a single constructor for both key gen and key loading. Its behavior depended on the optional x parameter to be non-zero.
reneme
force-pushed
the
feature/ecc_constructor
branch
from
370860d to
4c2132c
Compare
|
To be considered: When using the now-deprecated constructor we have access to an RNG. This allows us to do a random blinding when performing the multiplication with the base point, to get the associated public key. The new "key loading" constructor doesn't have an RNG and hence won't be able to use random blinding. However, the same is true for the existing (and probably much more useful) constructor taking an |
reneme
force-pushed
the
feature/ecc_constructor
branch
from
2d90f69 to
be5bbc2
Compare
|
Thanks! I had this on the docket re #4027 Re the removed RNG being used for blinding, indeed I think historically that is the reason for this (kind of weird in retrospect) combined generator-or-load constructor that took an RNG instance. |
randombit
approved these changes
Nov 18, 2024
randombit
added a commit
that referenced
this pull request
Jan 17, 2025
In #4437 new EC private key constructors were added, allowing deprecation of a quite confusing combined keygen/load constructor. However these new constructors take their input as a BigInt rather than the underlying EC_Scalar. Since #4437 has not been included in a release yet we can change these to take EC_Scalar directly, and avoid further entrenchment of BigInt in EC related interfaces.
randombit
added a commit
that referenced
this pull request
Jan 17, 2025
In #4437 new EC private key constructors were added, allowing deprecation of a quite confusing combined keygen/load constructor. However these new constructors take their input as a BigInt rather than the underlying EC_Scalar. Since #4437 has not been included in a release yet we can change these to take EC_Scalar directly, and avoid further entrenchment of BigInt in EC related interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ECC private keys provide two constructors:
AlgorithmIdentifierand key bitsEC_Groupand an optional secret value asBigIntThe second option either generates a new key or loads the optional secret value within the provided domain. If a user wants to load an ECC private key for which they don't have an
AlgorithmIdentifierhandy, they have to use this second constructor and "hope" that they'll use it correctly. E.g. by passing aNull_RNGto at least get some error if used incorrectly.This PR deprecates the second constructor and replaces it by two new ones:
Users that never call the now-deprecated constructor with the optional secret value won't ever see the deprecation. Their code will now just bind to the new "generating" constructor. This is achieved by making the secret value mandatory in the now-deprecated constructor.