Remove sphinx pinning #4839
Merged
Remove sphinx pinning #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vyasr
added
improvement
|
/ok to test |
|
/ok to test |
|
/ok to test |
jameslamb
approved these changes
Dec 20, 2024
|
/merge |
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
See rapidsai/cuvs#554, the switch to pip for Breathe in #4839 is no longer required. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - James Lamb (https://github.com/jameslamb) URL: #4842
rapids-bot bot
pushed a commit
to rapidsai/cugraph-docs
that referenced
this pull request
Jan 7, 2025
**This is exactly the same set of changes already approved in #69.** `cugraph-docs` was switched from private to public during the lifetime of that PR, which put CI into a state where that PR couldn't be merged: #69 (comment) --- Development and the vision for this project has stabilized here quite a bit over the last few weeks, so I think it's a good time to simplify things. This proposes the following: * removing configuration for codecov - *(there are no tests running here)* * removing patterns in CODEOWNERS that don't match any files * removing anything related to CUDA 11, pyproject.toml, or requirements.txt in `dependencies.yaml` and related files - *this repo exclusively uses conda, and only a single major version of CUDA* * updating to `sphinx>=8` and `breathe>=4.35` - *to match the rest of RAPIDS, e.g. rapidsai/cugraph#4839, rapidsai/cuvs#528 - *floors also mean faster conda solves and fewer surprises at build time* * removing unnecessary files in `ci/utils` - *these appear to have been copied from `cugraph`, but they're not needed as we don't do notebook testing here* ## Notes for Reviewers ### How I tested this Tested the `update-version.sh` changes like this: ```shell ./ci/release/update-version.sh '25.04.00' git grep -E '25\.2' git grep -E '25\.02' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Don Acosta (https://github.com/acostadon) - Ray Douglass (https://github.com/raydouglass) - Bradley Dice (https://github.com/bdice) URL: #71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pinning was needed for historical reasons that are no longer relevant.