Fix rviz crash issue if rviz is run later

ros-navigation · Jan 23, 2025 · 5fd8661 · 5fd8661
1 parent 091237e
commit 5fd8661
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/nav2_rviz_plugins/include/nav2_rviz_plugins/selector.hpp b/nav2_rviz_plugins/include/nav2_rviz_plugins/selector.hpp
@@ -54,7 +54,6 @@ class Selector : public rviz_common::Panel
   rclcpp::TimerBase::SharedPtr rclcpp_timer_;
 
   std::thread load_plugins_thread_;
-  std::mutex combo_box_mutex;
 
   QBasicTimer timer_;
   QVBoxLayout * main_layout_;

diff --git a/nav2_rviz_plugins/src/utils.cpp b/nav2_rviz_plugins/src/utils.cpp
@@ -24,7 +24,6 @@ void pluginLoader(
   rclcpp::Node::SharedPtr node, const std::string & server_name,
   const std::string & plugin_type, QComboBox * combo_box)
 {
-  RCLCPP_ERROR(node->get_logger(), "Loading plugins for %s", plugin_type.c_str());
   auto parameter_client = std::make_shared<rclcpp::SyncParametersClient>(node, server_name);
 
   // Wait for the service to be available before calling it
@@ -36,7 +35,6 @@ void pluginLoader(
   }
 
   auto parameters = parameter_client->get_parameters({plugin_type});
-  RCLCPP_ERROR(node->get_logger(), "Loaded %s plugins", plugin_type.c_str());
   auto str_arr = parameters[0].as_string_array();
   for (auto str : str_arr) {
     combo_box->addItem(QString::fromStdString(str));