Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_constrained_smoother: Use unsigned char instead of non-standard u_char type #4867

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

traversaro
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses No ticket.
Primary OS tested on Windows.
Robotic platform tested on This is just a compilation fix, no runtime changes.
Does this PR contain AI generated software? No.

Description of contribution in a few bullet points

u_char is not a standard C or C++ data type, while unsigned char is equivalent to u_char and is a standard data type. This change permits to compile nav2_constrained_smoother on Windows.

Description of documentation updates required from your changes

None.

Description of how this change was tested

I checked if the compilation was successful.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@traversaro
Copy link
Contributor Author

It seems that clang-format change the suggestion w.r.t. to some lines due to the additional length of unsigned char vs u_char, I will look into that.

@SteveMacenski
Copy link
Member

@traversaro CI, linting, and DCO are unhappy. Once you resolve, happy to merge :-)

@traversaro
Copy link
Contributor Author

DCO and linting fixed. I still need to understand more about the CI test failure.

@SteveMacenski SteveMacenski merged commit 59f1f70 into ros-navigation:main Jan 21, 2025
9 of 10 checks passed
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants