Explicit convert from std::filesystem::path to std::string for Windows compatibility #4870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
On Linux and macOS
std::filesystem::path
is implicitly convertible tostd::string
, while on Windows it is convertible tostd::wstring
, see https://en.cppreference.com/w/cpp/filesystem/path and https://stackoverflow.com/questions/57377349/implicit-conversion-between-stdfilesystempath-and-stdstring-should-it-hap . If we want to convertstd::filesystem::path
tostd::string
in a Windows-compatible way, it is then necessary to explicitly call the.string()
method.Description of documentation updates required from your changes
Description of how this change was tested
I checked if the program compiled.
Future work that may be required in bullet points
For Maintainers: