Fix rviz crash issue if run later #4871
Open
+31
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
On my machine, this not only stuck in getting parameter of planner, but also other plugins like controller, goal checker and so on. Thus, I did the following to solve this issue:
get_parameter()
would not block the main threadDescription of documentation updates required from your changes
None
Description of how this change was tested
Extensively tested on tb3 simulation
Future work that may be required in bullet points
On the original implementation, the combo box will appear blank if it cannot get parameter from service, I now put it a "default" on those labels, I think this will be better (otherwise users will click on an empty label).
I am not really familiar with QT, not sure if there is any problem in my implementation :)
Currently only tested on Jazzy, but I could build new images and test it on different distributions
For Maintainers: