Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang toolchain to resolve build error #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update golang toolchain to resolve build error #112

wants to merge 1 commit into from
+1 −1

Conversation

lightrush
Copy link

  • Error "/build/proton-bridge/go.mod:5: unknown directive: toolchain" seems to be caused by outdated toolchain.
  • Bumped toolchain to match what's in go.mod.

@lightrush
Update golang toolchain to resolve build error
5fbec27 
- Error "/build/proton-bridge/go.mod:5: unknown directive: toolchain"
seems to be caused by outdated toolchain.
- Bumped toolchain to match what's in go.mod.
lightrush
lightrush commented Jan 12, 2025
View reviewed changes
build/Dockerfile
@@ -1,5 +1,5 @@
# Use carlosedp/golang for riscv64 support
FROM carlosedp/golang:1.18 AS build
Copy link
Author

@lightrush lightrush Jan 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's anything special in the carlosedp golang image. I changed it to the upstream one which is based on Debian. Seems to work. I haven't tested ARM builds. I'm building on AMD64.

@lightrush
Copy link
Author

I see you have another PR to do this with a different solution. Feel free to close this if you prefer that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lightrush