Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang toolchain to resolve build error #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Use carlosedp/golang for riscv64 support
FROM carlosedp/golang:1.18 AS build
Copy link
Author

@lightrush lightrush Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's anything special in the carlosedp golang image. I changed it to the upstream one which is based on Debian. Seems to work. I haven't tested ARM builds. I'm building on AMD64.

FROM golang:1.21 AS build

# Install dependencies
RUN apt-get update && apt-get install -y git build-essential libsecret-1-dev
Expand Down