Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Functional Test Setup #1586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Functional Test Setup #1586

wants to merge 1 commit into from

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Dec 19, 2024

Description:

  • Added a work around step to the functional test setup function to use a new client to load newly deployed CRDs.
    • The Helm cli invalidates the discovery client cache more often than the Helm sdk, I made it so our use of the Helm sdk invalidates the cache appropriately like the Helm cli. Also started drafting a Helm sdk upstream fix for this.
    • This work around gets us closer to how customers use our product and we can likely apply this fix to other CRDs (cert manager, target allocator, prometheus) installed by our functional tests.
  • These changes fix only the no matches for kind "Instrumentation" in version "opentelemetry.io/v1alpha1" CRD errors specifically in our functional test code and CI/CD workflows.
  • Added a value section called instrumentation.jobs.startupapicheck that would be needed to configure the job image used.
  • After these changes functional tests still need to be updated for new golden file values or other recent breaking changes.

@jvoravong jvoravong force-pushed the functional-tests-fix branch from 28532fd to c4cde75 Compare December 20, 2024 21:19
@jvoravong jvoravong force-pushed the functional-tests-fix branch from c4cde75 to a1c6fee Compare December 20, 2024 21:34
@jvoravong jvoravong changed the title Functional Test Fix Fix Functional Test Setup Dec 20, 2024
@jvoravong jvoravong marked this pull request as ready for review December 20, 2024 21:48
@jvoravong jvoravong requested review from a team as code owners December 20, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant