-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Compatibility with astropy v7.1 #3375
Conversation
except ValueError: # Clearer error message | ||
raise ValueError('Missing or invalid counts conversion factor') | ||
else: | ||
if ctfac < 0: | ||
raise ValueError('Counts conversion factor cannot be negative ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message was swallowed by the ironic message that was supposed to make things clearer. I took it out of except block.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3375 +/- ##
==========================================
- Coverage 88.13% 88.12% -0.01%
==========================================
Files 127 127
Lines 19695 19699 +4
==========================================
+ Hits 17358 17360 +2
- Misses 2337 2339 +2 ☔ View full report in Codecov by Sentry. |
should we backport this or no? |
No need to auto backport as I already addressed it in #3376 |
Thanks for the review! |
Description
This pull request is to address compatibility with
str
orbytes
astropy/astropy#17586Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.