Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Compatibility with astropy v7.1 #3375

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 31, 2024

Description

This pull request is to address compatibility with

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Dec 31, 2024
@pllim pllim added this to the 4.2 milestone Dec 31, 2024
@github-actions github-actions bot added cubeviz specviz imviz plugin Label for plugins common to multiple configurations labels Dec 31, 2024
except ValueError: # Clearer error message
raise ValueError('Missing or invalid counts conversion factor')
else:
if ctfac < 0:
raise ValueError('Counts conversion factor cannot be negative '
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message was swallowed by the ironic message that was supposed to make things clearer. I took it out of except block.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (982bebb) to head (f5a6eb1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/core/unit_conversion_utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
- Coverage   88.13%   88.12%   -0.01%     
==========================================
  Files         127      127              
  Lines       19695    19699       +4     
==========================================
+ Hits        17358    17360       +2     
- Misses       2337     2339       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member

kecnry commented Jan 2, 2025

should we backport this or no?

@pllim
Copy link
Contributor Author

pllim commented Jan 2, 2025

No need to auto backport as I already addressed it in #3376

@pllim pllim merged commit e2faabf into spacetelescope:main Jan 2, 2025
29 of 30 checks passed
@pllim pllim deleted the fix-ci-main branch January 2, 2025 19:18
@pllim
Copy link
Contributor Author

pllim commented Jan 2, 2025

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations specviz trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants