Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Fix CI in v4.1.x branch #3376

Merged
merged 2 commits into from
Jan 3, 2025
Merged

TST: Fix CI in v4.1.x branch #3376

merged 2 commits into from
Jan 3, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 31, 2024 •
edited
Loading

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Dec 31, 2024
@pllim pllim added this to the 4.1.1 milestone Dec 31, 2024
@github-actions github-actions bot added cubeviz specviz imviz plugin Label for plugins common to multiple configurations labels Dec 31, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (4f2b4ff) to head (a702bb7).
Report is 4 commits behind head on v4.1.x.

Files with missing lines Patch % Lines
jdaviz/core/unit_conversion_utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v4.1.x    #3376      +/-   ##
==========================================
- Coverage   88.11%   88.10%   -0.01%     
==========================================
  Files         127      127              
  Lines       19574    19578       +4     
==========================================
+ Hits        17248    17250       +2     
- Misses       2326     2328       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review December 31, 2024 19:58
@pllim pllim mentioned this pull request Jan 2, 2025
Merged
9 tasks
cshanahan1
cshanahan1 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

i looked for any cases of strings as units that were uncovered by tests and i couldn't find any, so this seems like all of it.

jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
@@ -369,7 +369,7 @@ def _uncertainty(result):
self.update_results(None)
return
# When flux is equivalent to Jy, lineflux result should be shown in W/m2
if flux_unit.is_equivalent(u.Unit('W/(m2 m)'/solid_angle_in_flux_unit)):
if flux_unit.is_equivalent(u.W / (u.m * u.m * u.m * solid_angle_in_flux_unit)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why this swap here? there are many cases of creating units from strings that aren't changed (or possible to change, i think). is this preferred when possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't comb through the whole package but I change it when I see it in the diff. There is no reason to incur extra overhead of string parsing if you already know what you want.

@pllim pllim merged commit ead4035 into spacetelescope:v4.1.x Jan 3, 2025
28 of 29 checks passed
@pllim
Copy link
Contributor Author

pllim commented Jan 3, 2025

Thanks for the review!

@pllim pllim deleted the fix-ci-v4.1.x branch January 3, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cshanahan1 cshanahan1 cshanahan1 approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
cubeviz imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations specviz trivial Only needs one approval instead of two
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @cshanahan1