NRC TA plot enhancements

[mperrin]

Some minor enhancements to the nrc_ta_image_comparison function.

• Adds an optional show_centroid parameter, which toggles a plot annotation showing the centroid location of the TA image. This includes a centroid measured using the fwcentroid code in poppy+webbpsf, and (optionally but automatically, if my misc_jwst toolkit is available, the onboard OSS centroids retrieved from the MAST engineering database).
• Generalizes some bits of this function, so it will work on any NIRCam TA exposure, not just the WFS program. This allows the same code to be used for similar analyses of coronagraphic or TSO target acquisitions with NIRCam.

Probably fairly specialized use cases, but since I have this code now for myself it seems worthwhile to include it here to share.

Example with centroid over plotting:

Example showing a NIRCam coron target acq:

[obi-wan76]

@Skyhawk172 since you have been using this function you may want to try the new minor additions.

[Skyhawk172]

To test it out, I installed misc_jwst but it crashed because I apparently haven't set up my MAST_API_TOKEN environment variable. There's a built-in exception handler in engdb.get_ictm_event_log that terminates the execution. So, until I set the env. variable, I'm now stuck and can't run the code because it will always go with misc_jwst since it's installed. I think in such cases, the code should naturally revert to calculating the centroid using webbpsf methods, instead of halting altogether.

I think it'd be nice to be able to compare the two ways to measure the centroids; could the code calculate and report both centroids and (1) use the OSS if misc_jwst is successful or (2) use the WebbPSF centroid otherwise?

[mperrin]

ok, I can rework/improve the exception handling here.

Yes, the intent of this part of the code is to compare the two ways to measure the centroids. It tries to get the OSS centroid, and the webbpsf centroid, and display and print both of them. As of Friday, in code not yet added to this PR, it also uses the WCS to retrieve where the star is "supposed to be" after the FGS acq, so it can also quantify directly what the pointing accuracy is after the FGS acq.

[mperrin]

OK @Skyhawk172, please update to the latest misc_jwst (as of a minute ago), and retry. I think it should allow access to the eng db without requiring the API token to be set now.

[Skyhawk172]

Hmmm, I'm getting a different error now:

File ~/opt/anaconda3/envs/py310/lib/python3.10/site-packages/misc_jwst/engdb.py:40, in get_ictm_event_log(startdate, enddate, mast_api_token, verbose, return_as_table)
---> 40 start = datetime.fromisoformat(f'{startdate}+00:00')
     41 if enddate is None:
     42     end = datetime.now(tz=tz_utc)

ValueError: Invalid isoformat string: '2024-01-14 18:55:49.4420000+00:00'

[mperrin]

Oh, that parameter is just right now expecting startdate to be like "2024-01-14" with nothing after that. Can fix that too to be more general.

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/mast_wss.py:

Line 16:1: E266 too many leading '#' for block comment
Line 46:72: E703 statement ends with a semicolon
Line 60:1: E266 too many leading '#' for block comment
Line 86:9: E265 block comment should start with '# '
Line 91:27: E226 missing whitespace around arithmetic operator
Line 104:23: E226 missing whitespace around arithmetic operator
Line 105:23: E701 multiple statements on one line (colon)
Line 113:27: E701 multiple statements on one line (colon)
Line 204:19: E701 multiple statements on one line (colon)
Line 208:19: E701 multiple statements on one line (colon)
Line 212:19: E701 multiple statements on one line (colon)
Line 218:9: E122 continuation line missing indentation or outdented
Line 219:19: E701 multiple statements on one line (colon)
Line 221:57: E251 unexpected spaces around keyword / parameter equals
Line 221:59: E251 unexpected spaces around keyword / parameter equals
Line 225:1: E266 too many leading '#' for block comment
Line 225:1: E303 too many blank lines (3)
Line 227:1: E302 expected 2 blank lines, found 3
Line 298:1: E266 too many leading '#' for block comment
Line 349:5: E303 too many blank lines (2)
Line 376:1: E302 expected 2 blank lines, found 1
Line 386:13: E128 continuation line under-indented for visual indent
Line 394:1: E302 expected 2 blank lines, found 1
Line 464:5: E265 block comment should start with '# '
Line 465:5: E265 block comment should start with '# '
Line 471:33: E231 missing whitespace after ','
Line 479:5: E265 block comment should start with '# '
Line 485:23: E701 multiple statements on one line (colon)
Line 495:23: E701 multiple statements on one line (colon)
Line 560:40: E701 multiple statements on one line (colon)
Line 601:13: E126 continuation line over-indented for hanging indent
Line 601:39: E261 at least two spaces before inline comment
Line 603:12: E126 continuation line over-indented for hanging indent
Line 606:29: E203 whitespace before ':'
Line 606:43: E203 whitespace before ':'
Line 609:5: E303 too many blank lines (2)
Line 611:11: E128 continuation line under-indented for visual indent
Line 612:10: E124 closing bracket does not match visual indentation
Line 645:5: E303 too many blank lines (3)
Line 671:24: E231 missing whitespace after ':'
Line 675:17: E124 closing bracket does not match visual indentation
Line 683:29: E203 whitespace before ':'
Line 683:43: E203 whitespace before ':'
Line 686:5: E303 too many blank lines (2)
Line 686:41: E231 missing whitespace after ','
Line 698:5: E303 too many blank lines (2)
Line 701:28: E201 whitespace after '('
Line 701:33: E226 missing whitespace around arithmetic operator
Line 703:16: E225 missing whitespace around operator
Line 706:1: E302 expected 2 blank lines, found 1
Line 706:39: E241 multiple spaces after ','
Line 731:5: E303 too many blank lines (2)
Line 732:13: E225 missing whitespace around operator
Line 735:5: E265 block comment should start with '# '

• In the file webbpsf/match_data.py:

Line 1:1: E266 too many leading '#' for block comment
Line 26:38: E231 missing whitespace after ','
Line 37:17: E225 missing whitespace around operator
Line 37:46: E225 missing whitespace around operator
Line 40:20: E225 missing whitespace around operator
Line 46:20: E225 missing whitespace around operator
Line 49:51: E226 missing whitespace around arithmetic operator
Line 49:55: E226 missing whitespace around arithmetic operator
Line 53:5: E303 too many blank lines (2)
Line 59:47: E271 multiple spaces after keyword
Line 59:66: E225 missing whitespace around operator
Line 64:80: E114 indentation is not a multiple of four (comment)
Line 64:80: E116 unexpected indentation (comment)
Line 71:45: E117 over-indented (comment)
Line 76:37: E226 missing whitespace around arithmetic operator
Line 102:1: E303 too many blank lines (3)
Line 133:16: E225 missing whitespace around operator
Line 161:41: E226 missing whitespace around arithmetic operator
Line 163:22: E225 missing whitespace around operator
Line 167:58: E225 missing whitespace around operator
Line 212:52: E225 missing whitespace around operator
Line 212:75: E225 missing whitespace around operator

• In the file webbpsf/trending.py:

Line 20:1: E302 expected 2 blank lines, found 1
Line 30:1: E302 expected 2 blank lines, found 1
Line 33:88: E261 at least two spaces before inline comment
Line 36:33: E128 continuation line under-indented for visual indent
Line 87:15: E265 block comment should start with '# '
Line 89:15: E265 block comment should start with '# '
Line 90:15: E265 block comment should start with '# '
Line 96:15: E265 block comment should start with '# '
Line 105:56: E261 at least two spaces before inline comment
Line 131:25: E226 missing whitespace around arithmetic operator
Line 133:25: E226 missing whitespace around arithmetic operator
Line 138:47: E226 missing whitespace around arithmetic operator
Line 159:13: E265 block comment should start with '# '
Line 192:1: E303 too many blank lines (3)
Line 193:25: E127 continuation line over-indented for visual indent
Line 223:5: E303 too many blank lines (2)
Line 239:10: E225 missing whitespace around operator
Line 251:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 253:27: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 260:73: E226 missing whitespace around arithmetic operator
Line 263:64: E231 missing whitespace after ','
Line 281:10: E221 multiple spaces before operator
Line 282:41: E231 missing whitespace after ','
Line 282:71: E251 unexpected spaces around keyword / parameter equals
Line 282:73: E251 unexpected spaces around keyword / parameter equals
Line 282:83: E231 missing whitespace after ':'
Line 284:12: E261 at least two spaces before inline comment
Line 284:13: E262 inline comment should start with '# '
Line 286:57: E226 missing whitespace around arithmetic operator
Line 291:24: E225 missing whitespace around operator
Line 300:26: E225 missing whitespace around operator
Line 301:34: E226 missing whitespace around arithmetic operator
Line 301:47: E225 missing whitespace around operator
Line 302:81: E226 missing whitespace around arithmetic operator
Line 304:26: E225 missing whitespace around operator
Line 305:17: E222 multiple spaces after operator
Line 305:36: E226 missing whitespace around arithmetic operator
Line 307:50: E226 missing whitespace around arithmetic operator
Line 309:23: E221 multiple spaces before operator
Line 311:18: E222 multiple spaces after operator
Line 311:24: E226 missing whitespace around arithmetic operator
Line 320:31: E226 missing whitespace around arithmetic operator
Line 320:35: E226 missing whitespace around arithmetic operator
Line 321:33: E226 missing whitespace around arithmetic operator
Line 325:31: E226 missing whitespace around arithmetic operator
Line 325:60: E226 missing whitespace around arithmetic operator
Line 328:11: E221 multiple spaces before operator
Line 334:22: E128 continuation line under-indented for visual indent
Line 339:60: E251 unexpected spaces around keyword / parameter equals
Line 339:62: E251 unexpected spaces around keyword / parameter equals
Line 341:10: E225 missing whitespace around operator
Line 343:23: E201 whitespace after '('
Line 343:43: E226 missing whitespace around arithmetic operator
Line 344:23: E201 whitespace after '('
Line 344:43: E226 missing whitespace around arithmetic operator
Line 347:22: E128 continuation line under-indented for visual indent
Line 349:44: E226 missing whitespace around arithmetic operator
Line 355:31: E226 missing whitespace around arithmetic operator
Line 355:111: E703 statement ends with a semicolon
Line 360:30: E226 missing whitespace around arithmetic operator
Line 365:24: E231 missing whitespace after ','
Line 371:37: E226 missing whitespace around arithmetic operator
Line 371:57: E226 missing whitespace around arithmetic operator
Line 372:30: E226 missing whitespace around arithmetic operator
Line 372:35: E226 missing whitespace around arithmetic operator
Line 372:41: E226 missing whitespace around arithmetic operator
Line 372:53: E226 missing whitespace around arithmetic operator
Line 373:22: E128 continuation line under-indented for visual indent
Line 374:21: E128 continuation line under-indented for visual indent
Line 377:5: E303 too many blank lines (2)
Line 381:50: E226 missing whitespace around arithmetic operator
Line 382:17: E225 missing whitespace around operator
Line 390:1: E266 too many leading '#' for block comment
Line 392:1: E302 expected 2 blank lines, found 1
Line 416:35: E226 missing whitespace around arithmetic operator
Line 428:35: E226 missing whitespace around arithmetic operator
Line 429:20: E128 continuation line under-indented for visual indent
Line 430:20: E128 continuation line under-indented for visual indent
Line 431:20: E128 continuation line under-indented for visual indent
Line 434:5: E303 too many blank lines (2)
Line 515:67: E225 missing whitespace around operator
Line 521:5: E303 too many blank lines (2)
Line 537:75: E231 missing whitespace after ':'
Line 537:81: E226 missing whitespace around arithmetic operator
Line 538:44: E225 missing whitespace around operator
Line 578:5: E303 too many blank lines (2)
Line 584:30: E225 missing whitespace around operator
Line 589:5: E266 too many leading '#' for block comment
Line 589:5: E303 too many blank lines (2)
Line 603:5: E266 too many leading '#' for block comment
Line 603:5: E303 too many blank lines (2)
Line 604:13: E225 missing whitespace around operator
Line 608:81: E226 missing whitespace around arithmetic operator
Line 613:102: E226 missing whitespace around arithmetic operator
Line 639:5: E266 too many leading '#' for block comment
Line 645:92: E226 missing whitespace around arithmetic operator
Line 650:91: E226 missing whitespace around arithmetic operator
Line 655:74: E226 missing whitespace around arithmetic operator
Line 660:70: E226 missing whitespace around arithmetic operator
Line 662:5: E266 too many leading '#' for block comment
Line 667:75: E226 missing whitespace around arithmetic operator
Line 672:66: E226 missing whitespace around arithmetic operator
Line 680:60: E225 missing whitespace around operator
Line 683:93: E226 missing whitespace around arithmetic operator
Line 688:5: E303 too many blank lines (2)
Line 690:78: E226 missing whitespace around arithmetic operator
Line 695:70: E226 missing whitespace around arithmetic operator
Line 743:5: E303 too many blank lines (2)
Line 764:1: E305 expected 2 blank lines after class or function definition, found 1
Line 819:19: E701 multiple statements on one line (colon)
Line 822:5: E303 too many blank lines (2)
Line 822:74: W504 line break after binary operator
Line 829:5: E266 too many leading '#' for block comment
Line 873:48: E226 missing whitespace around arithmetic operator
Line 913:49: W605 invalid escape sequence '\D'
Line 945:1: E266 too many leading '#' for block comment
Line 958:46: E241 multiple spaces after ','
Line 975:43: E203 whitespace before ':'
Line 990:1: E303 too many blank lines (3)
Line 1047:5: E303 too many blank lines (2)
Line 1050:47: E225 missing whitespace around operator
Line 1051:18: E221 multiple spaces before operator
Line 1053:70: E225 missing whitespace around operator
Line 1054:75: E202 whitespace before ']'
Line 1063:51: E261 at least two spaces before inline comment
Line 1063:51: E262 inline comment should start with '# '
Line 1064:41: E201 whitespace after '('
Line 1064:64: E202 whitespace before ')'
Line 1067:5: E722 do not use bare 'except'
Line 1088:5: E303 too many blank lines (2)
Line 1089:19: E701 multiple statements on one line (colon)
Line 1174:98: W504 line break after binary operator
Line 1199:49: E231 missing whitespace after ','
Line 1210:5: E266 too many leading '#' for block comment
Line 1222:5: E265 block comment should start with '# '
Line 1222:5: E303 too many blank lines (2)
Line 1223:5: E265 block comment should start with '# '
Line 1224:26: E201 whitespace after '('
Line 1225:30: E231 missing whitespace after ','
Line 1227:25: E226 missing whitespace around arithmetic operator
Line 1227:39: E226 missing whitespace around arithmetic operator
Line 1227:48: E226 missing whitespace around arithmetic operator
Line 1227:62: E226 missing whitespace around arithmetic operator
Line 1231:5: E266 too many leading '#' for block comment
Line 1242:60: E226 missing whitespace around arithmetic operator
Line 1242:71: E226 missing whitespace around arithmetic operator
Line 1242:88: E226 missing whitespace around arithmetic operator
Line 1242:94: E261 at least two spaces before inline comment
Line 1244:74: E226 missing whitespace around arithmetic operator
Line 1245:36: W605 invalid escape sequence '\D'
Line 1247:32: E226 missing whitespace around arithmetic operator
Line 1247:34: E226 missing whitespace around arithmetic operator
Line 1251:26: E201 whitespace after '('
Line 1259:5: E303 too many blank lines (2)
Line 1272:49: E226 missing whitespace around arithmetic operator
Line 1273:23: E225 missing whitespace around operator
Line 1273:32: E225 missing whitespace around operator
Line 1305:146: E226 missing whitespace around arithmetic operator
Line 1308:132: E226 missing whitespace around arithmetic operator
Line 1328:30: E261 at least two spaces before inline comment
Line 1330:134: E226 missing whitespace around arithmetic operator
Line 1333:132: E226 missing whitespace around arithmetic operator
Line 1341:22: E231 missing whitespace after ','
Line 1344:46: E251 unexpected spaces around keyword / parameter equals
Line 1344:48: E251 unexpected spaces around keyword / parameter equals
Line 1349:48: E226 missing whitespace around arithmetic operator
Line 1349:52: E226 missing whitespace around arithmetic operator
Line 1349:66: E226 missing whitespace around arithmetic operator
Line 1349:70: E226 missing whitespace around arithmetic operator
Line 1350:40: E128 continuation line under-indented for visual indent
Line 1380:5: E303 too many blank lines (2)
Line 1392:50: E226 missing whitespace around arithmetic operator
Line 1392:54: E226 missing whitespace around arithmetic operator
Line 1392:82: E226 missing whitespace around arithmetic operator
Line 1395:69: E226 missing whitespace around arithmetic operator
Line 1396:67: E231 missing whitespace after ','
Line 1398:69: E226 missing whitespace around arithmetic operator
Line 1399:67: E231 missing whitespace after ','
Line 1403:5: E303 too many blank lines (3)
Line 1404:41: E231 missing whitespace after ','
Line 1404:83: E231 missing whitespace after ':'
Line 1404:97: E231 missing whitespace after ':'
Line 1404:112: E231 missing whitespace after ':'
Line 1405:85: E231 missing whitespace after ':'
Line 1405:97: E231 missing whitespace after ':'
Line 1408:5: E303 too many blank lines (2)
Line 1408:11: E231 missing whitespace after ','
Line 1409:11: E231 missing whitespace after ','
Line 1411:11: E231 missing whitespace after ','
Line 1411:29: E226 missing whitespace around arithmetic operator
Line 1412:11: E231 missing whitespace after ','
Line 1412:29: E226 missing whitespace around arithmetic operator
Line 1414:11: E231 missing whitespace after ','
Line 1414:28: E226 missing whitespace around arithmetic operator
Line 1414:36: E226 missing whitespace around arithmetic operator
Line 1415:11: E231 missing whitespace after ','
Line 1415:28: E226 missing whitespace around arithmetic operator
Line 1415:36: E226 missing whitespace around arithmetic operator
Line 1418:5: E303 too many blank lines (2)
Line 1419:41: E226 missing whitespace around arithmetic operator
Line 1419:48: E226 missing whitespace around arithmetic operator
Line 1420:41: E226 missing whitespace around arithmetic operator
Line 1420:48: E226 missing whitespace around arithmetic operator
Line 1421:11: E231 missing whitespace after ','
Line 1421:22: E231 missing whitespace after ','
Line 1422:11: E231 missing whitespace after ','
Line 1422:22: E231 missing whitespace after ','
Line 1425:5: E303 too many blank lines (2)
Line 1425:11: E231 missing whitespace after ','
Line 1426:11: E231 missing whitespace after ','
Line 1427:11: E231 missing whitespace after ','
Line 1428:11: E231 missing whitespace after ','
Line 1429:11: E231 missing whitespace after ','
Line 1434:5: E303 too many blank lines (2)
Line 1435:26: E251 unexpected spaces around keyword / parameter equals
Line 1435:28: E251 unexpected spaces around keyword / parameter equals
Line 1435:35: E231 missing whitespace after ','
Line 1435:94: E202 whitespace before ')'
Line 1483:5: E303 too many blank lines (2)
Line 1488:51: E226 missing whitespace around arithmetic operator
Line 1488:55: E226 missing whitespace around arithmetic operator
Line 1488:84: E225 missing whitespace around operator
Line 1491:71: E226 missing whitespace around arithmetic operator
Line 1492:69: E231 missing whitespace after ','
Line 1494:71: E226 missing whitespace around arithmetic operator
Line 1495:69: E231 missing whitespace after ','
Line 1498:5: E303 too many blank lines (2)
Line 1499:41: E231 missing whitespace after ','
Line 1499:83: E231 missing whitespace after ':'
Line 1499:96: E231 missing whitespace after ':'
Line 1499:110: E231 missing whitespace after ':'
Line 1500:76: E128 continuation line under-indented for visual indent
Line 1500:84: E231 missing whitespace after ':'
Line 1500:96: E231 missing whitespace after ':'
Line 1503:5: E303 too many blank lines (2)
Line 1503:11: E231 missing whitespace after ','
Line 1504:11: E231 missing whitespace after ','
Line 1506:11: E231 missing whitespace after ','
Line 1506:29: E226 missing whitespace around arithmetic operator
Line 1507:11: E231 missing whitespace after ','
Line 1507:29: E226 missing whitespace around arithmetic operator
Line 1509:11: E231 missing whitespace after ','
Line 1509:29: E226 missing whitespace around arithmetic operator
Line 1509:38: E226 missing whitespace around arithmetic operator
Line 1510:11: E231 missing whitespace after ','
Line 1510:29: E226 missing whitespace around arithmetic operator
Line 1510:38: E226 missing whitespace around arithmetic operator
Line 1513:42: E226 missing whitespace around arithmetic operator
Line 1513:51: E226 missing whitespace around arithmetic operator
Line 1514:42: E226 missing whitespace around arithmetic operator
Line 1514:51: E226 missing whitespace around arithmetic operator
Line 1515:11: E231 missing whitespace after ','
Line 1515:21: E231 missing whitespace after ','
Line 1516:11: E231 missing whitespace after ','
Line 1516:21: E231 missing whitespace after ','
Line 1520:5: E303 too many blank lines (3)
Line 1520:11: E231 missing whitespace after ','
Line 1521:11: E231 missing whitespace after ','
Line 1522:11: E231 missing whitespace after ','
Line 1523:11: E231 missing whitespace after ','
Line 1524:11: E231 missing whitespace after ','
Line 1529:5: E303 too many blank lines (2)
Line 1530:26: E251 unexpected spaces around keyword / parameter equals
Line 1530:28: E251 unexpected spaces around keyword / parameter equals
Line 1530:35: E231 missing whitespace after ','
Line 1530:94: E202 whitespace before ')'
Line 1533:5: E303 too many blank lines (2)
Line 1555:5: E731 do not assign a lambda expression, use a def
Line 1558:19: E701 multiple statements on one line (colon)
Line 1562:16: E225 missing whitespace around operator
Line 1584:33: E231 missing whitespace after ','
Line 1586:85: E231 missing whitespace after ','
Line 1594:5: E303 too many blank lines (2)
Line 1596:18: E128 continuation line under-indented for visual indent
Line 1596:20: E231 missing whitespace after ','
Line 1596:22: E231 missing whitespace after ','
Line 1609:35: E231 missing whitespace after ','
Line 1612:15: E201 whitespace after '('
Line 1612:35: E226 missing whitespace around arithmetic operator
Line 1612:44: E226 missing whitespace around arithmetic operator
Line 1612:64: E226 missing whitespace around arithmetic operator
Line 1613:15: E128 continuation line under-indented for visual indent
Line 1614:14: E128 continuation line under-indented for visual indent
Line 1615:15: E201 whitespace after '('
Line 1615:24: E226 missing whitespace around arithmetic operator
Line 1615:43: E226 missing whitespace around arithmetic operator
Line 1615:52: E226 missing whitespace around arithmetic operator
Line 1616:15: E128 continuation line under-indented for visual indent
Line 1617:14: E128 continuation line under-indented for visual indent
Line 1622:20: E128 continuation line under-indented for visual indent
Line 1626:35: E226 missing whitespace around arithmetic operator
Line 1627:39: E226 missing whitespace around arithmetic operator
Line 1627:48: E226 missing whitespace around arithmetic operator
Line 1628:28: E226 missing whitespace around arithmetic operator
Line 1628:48: E226 missing whitespace around arithmetic operator
Line 1633:14: E128 continuation line under-indented for visual indent
Line 1636:5: E303 too many blank lines (2)
Line 1639:19: E225 missing whitespace around operator
Line 1642:9: E225 missing whitespace around operator
Line 1643:47: E226 missing whitespace around arithmetic operator
Line 1643:55: E226 missing whitespace around arithmetic operator
Line 1645:49: E226 missing whitespace around arithmetic operator
Line 1645:57: E226 missing whitespace around arithmetic operator
Line 1647:46: E226 missing whitespace around arithmetic operator
Line 1647:54: E226 missing whitespace around arithmetic operator
Line 1650:47: E226 missing whitespace around arithmetic operator
Line 1650:59: E226 missing whitespace around arithmetic operator
Line 1650:67: E226 missing whitespace around arithmetic operator
Line 1654:55: E251 unexpected spaces around keyword / parameter equals
Line 1654:57: E251 unexpected spaces around keyword / parameter equals
Line 1696:5: E303 too many blank lines (2)
Line 1699:57: E226 missing whitespace around arithmetic operator
Line 1699:64: E226 missing whitespace around arithmetic operator
Line 1705:19: E222 multiple spaces after operator
Line 1727:53: E226 missing whitespace around arithmetic operator
Line 1734:31: E225 missing whitespace around operator
Line 1740:5: E303 too many blank lines (2)
Line 1745:32: E226 missing whitespace around arithmetic operator
Line 1756:33: E225 missing whitespace around operator
Line 1757:51: E226 missing whitespace around arithmetic operator
Line 1761:42: E231 missing whitespace after ','
Line 1765:56: E231 missing whitespace after ','
Line 1770:28: E226 missing whitespace around arithmetic operator
Line 1770:87: E203 whitespace before ','
Line 1773:28: E231 missing whitespace after ','
Line 1774:25: E128 continuation line under-indented for visual indent
Line 1775:55: E226 missing whitespace around arithmetic operator
Line 1777:18: E231 missing whitespace after ','
Line 1821:25: W605 invalid escape sequence '\D'
Line 1829:1: E266 too many leading '#' for block comment
Line 1844:52: E251 unexpected spaces around keyword / parameter equals
Line 1844:54: E251 unexpected spaces around keyword / parameter equals
Line 1844:59: E226 missing whitespace around arithmetic operator
Line 1844:77: E261 at least two spaces before inline comment
Line 1844:78: E262 inline comment should start with '# '
Line 1845:47: E226 missing whitespace around arithmetic operator
Line 1870:41: E231 missing whitespace after ','
Line 1902:43: E226 missing whitespace around arithmetic operator
Line 1906:9: E266 too many leading '#' for block comment
Line 1933:13: E266 too many leading '#' for block comment
Line 1939:64: E226 missing whitespace around arithmetic operator
Line 1941:22: E128 continuation line under-indented for visual indent
Line 1942:22: E128 continuation line under-indented for visual indent
Line 1943:22: E128 continuation line under-indented for visual indent
Line 1953:9: E266 too many leading '#' for block comment
Line 1957:82: E226 missing whitespace around arithmetic operator
Line 1965:22: E225 missing whitespace around operator
Line 1973:19: E126 continuation line over-indented for hanging indent
Line 1974:27: E251 unexpected spaces around keyword / parameter equals
Line 1974:29: E251 unexpected spaces around keyword / parameter equals
Line 1974:82: E225 missing whitespace around operator
Line 1978:21: E128 continuation line under-indented for visual indent
Line 1983:5: E303 too many blank lines (2)

Comment last updated at 2024-04-02 16:31:23 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 4.00000% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 59.39%. Comparing base (c5ea52d) to head (ff4904e).

Files	Patch %	Lines
webbpsf/trending.py	3.70%	52 Missing ⚠️
webbpsf/mast_wss.py	5.88%	16 Missing ⚠️
webbpsf/match_data.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    59.91%   59.39%   -0.52%     
===========================================
  Files           16       16              
  Lines         6865     6925      +60     
===========================================
  Hits          4113     4113              
- Misses        2752     2812      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mperrin]

@obi-wan76 @obi-wan76 Wanted to ping you about this and ask if either of you will be able to review this PR, and if so by when?

[obi-wan76]

@mperrin when I ran it on one of our sensing programs I got:
ValueError: Instrument NIRCam doesn't have a pupil mask called 'CLEAR'.
This should be fixed in the PR #768 . Do you need to rebase this PR to get those changes?

[mperrin]

yeah I'm working on rebasing and deconflicting now 👍

[mperrin]

@obi-wan76 eh, looks like some other change broke things: that error shows up for the code in develop too now, not just this PR. I'll fix it in this branch in any case.

[obi-wan76]

This is working for me now, looks good.