feat(consensus): add config to Context

[guy-starkware]

Adds a ContextConfig struct that is used by the two context structs.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• chore(consensus): move some network parameter consts into config #3380
• chore(consensus): remove some fields from ConsensusConfig #3379
• chore(consensus): add PapyrusConsensusConfig struct #3377
• chore(consensus): update ConsensusManagerConfig with new parameters #3340
• chore(consensus): add ContextConfig to SequencerConcensusContext #3338
• feat(consensus): add config to Context #3268 👈 (View in Graphite)
• chore(consensus): remove default value for chain_id config parameter #2898 : 1 other dependent PR (#3130 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-16T09:43:14Z
• Started at 2025-01-16T09:43:14Z

[asmaastarkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dan-starkware, @giladchase, and @guy-starkware)

---

crates/papyrus_node/src/config/mod.rs line 12 at r1 (raw file):

use std::ops::IndexMut;
use std::path::{Path, PathBuf};
use std::task::Context;

unused right?

---

crates/papyrus_node/src/config/mod.rs line 69 at r1 (raw file):

    pub p2p_sync: Option<P2pSyncClientConfig>,
    pub consensus: Option<ConsensusConfig>,
    pub context: ContextConfig,

make it optional, and apply the relevant changes

Suggestion:

pub context: Option<ContextConfig>,

---

crates/sequencing/papyrus_consensus/src/types.rs line 35 at r1 (raw file):

/// Configuration for the Context struct.
#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Validate)]
pub struct ContextConfig {

why not adding it to the context dir?

---

crates/sequencing/papyrus_consensus/src/types.rs line 41 at r1 (raw file):

    pub num_validators: u64,
    /// The chain id of the Starknet chain.
    pub chain_id: ChainId,

both num_validators and chain_id are part of the consensus config and are passed to the context. I suggest either removing them now or adding a TODO to complete the concept within the PR.
also to add batcher_build_buffer when its used (if we still want to add it to the config since the papyrus context doesn't interact with the batcher)

---

crates/sequencing/papyrus_consensus_orchestrator/src/papyrus_consensus_context_test.rs line 145 at r1 (raw file):

    let papyrus_context = PapyrusConsensusContext::new(
        ContextConfig::default(),

by default its 1 not 4.. tests are safe :)

[guy-starkware]

Reviewable status: 3 of 9 files reviewed, 4 unresolved discussions (waiting on @asmaastarkware, @dan-starkware, and @giladchase)

---

crates/papyrus_node/src/config/mod.rs line 12 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

unused right?

yes! I wonder why clippy didn't see that...

---

crates/papyrus_node/src/config/mod.rs line 69 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

make it optional, and apply the relevant changes

Done.

---

crates/sequencing/papyrus_consensus/src/types.rs line 35 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

why not adding it to the context dir?

I'm not really happy about having it in types.rs either.

I think I should do a PR at the end of the stack where I move the ContextConfig to another place. I'm not sure where it will be, if you have a place you think is right, let me know.

---

crates/sequencing/papyrus_consensus/src/types.rs line 41 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

both num_validators and chain_id are part of the consensus config and are passed to the context. I suggest either removing them now or adding a TODO to complete the concept within the PR.
also to add batcher_build_buffer when its used (if we still want to add it to the config since the papyrus context doesn't interact with the batcher)

I added a TODO. This happens in another PR on this stack.

---

crates/sequencing/papyrus_consensus_orchestrator/src/papyrus_consensus_context_test.rs line 145 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

by default its 1 not 4.. tests are safe :)

I think I had an issue with the number of validators in one of the tests in the next PRs. I don't remember exactly.