chore(consensus): update ConsensusManagerConfig with new parameters #3340
+134
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
guy-starkware
force-pushed
the
guyn/config/sequencer_context_config
branch
2 times, most recently
from
a57408c to
30748e8
Compare
guy-starkware
force-pushed
the
guyn/config/consensus_manager_config
branch
from
8e1a680 to
4c3caf1
Compare
|
Artifacts upload workflows: |
guy-starkware
force-pushed
the
guyn/config/sequencer_context_config
branch
from
30748e8 to
407201c
Compare
guy-starkware
force-pushed
the
guyn/config/consensus_manager_config
branch
from
4c3caf1 to
f1cfc9e
Compare
This was referenced Jan 16, 2025
guy-starkware
force-pushed
the
guyn/config/sequencer_context_config
branch
from
407201c to
4d20b96
Compare
guy-starkware
force-pushed
the
guyn/config/consensus_manager_config
branch
from
f1cfc9e to
2c57fef
Compare
guy-starkware
force-pushed
the
guyn/config/sequencer_context_config
branch
from
4d20b96 to
75df68a
Compare
guy-starkware
force-pushed
the
guyn/config/consensus_manager_config
branch
from
2c57fef to
298f522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few missing fields to the ConsensusManagerConfig struct.
One of them is network_config, which is also removed from ConsensusConfig.
The ConsensusConfig needs a few other modifications, but I'll get to them in one of the next PRs.