Add router_cores and get_core_at #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
reviewed
Jan 3, 2025
broskoTT
commented
Jan 3, 2025
broskoTT
commented
Jan 3, 2025
broskoTT
force-pushed
the
brosko/get_coord
branch
from
4c56cde to
1580592
Compare
broskoTT
force-pushed
the
brosko/get_coord
branch
from
39e764c to
5104318
Compare
broskoTT
added a commit
that referenced
this pull request
Jan 22, 2025
### Issue Continuation of #446 ### Description Minor fixes ### List of the changes - Added the translate_coord_to api to soc descriptor as well - Added more verbose fatal messages for translation. ### Testing No additional tests ### API Changes There are no API changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Somewhat related to #439
Description
get_core_at can be a useful API provided by coordinate manager. There are scenarios where we want to learn what is located at a specific core location. This obviously can't be offered for LOGICAL coord system, but for others it is possible.
Since there are also some places in the code which request specifically some cores which might be router_only cores, I've also added router_cores to CoordinateManager and SocDescriptor (see Cluster::test_setup_interface or Cluster::broadcast_pcie_tensix_risc_reset)
List of the changes
Testing
Added tests which test the new API.
API Changes
There are no API changes in this PR.