Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node cleanup #109

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Node cleanup #109

merged 7 commits into from
Jul 12, 2024

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Jul 11, 2024

These commits make the usage and naming of nodes and internal nodes more consistent. Also, executors and callback groups are simplified to SingleThreaded and MutuallyExclusive where possible (the MultiThreadedExecutor has lower performance).

@rjoomen rjoomen requested a review from marrts July 11, 2024 17:43
@marrts
Copy link
Contributor

marrts commented Jul 12, 2024

This looks good to me and is working, however when I first tested it I ran into an issue where my environment wasn't updating because I was using the DEFAULT_JOINT_STATES_TOPIC param from here which absorbs the namespace of the node. I feel like the default topic should be /joint_states to avoid getting namespaced and more predictable, consistent behavior.

@rjoomen rjoomen merged commit 9196308 into tesseract-robotics:master Jul 12, 2024
6 of 8 checks passed
@rjoomen rjoomen deleted the node_cleanup branch July 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants