[Player] Unified caching (1/X): Remove AVQueuePlayerWrapperLegacy implementation
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
alberto/fix-player-output-sample-rate
to
main
November 28, 2024 15:58
asendra
force-pushed
the
alberto/remove-legacy-player-impl
branch
2 times, most recently
from
c14cd75 to
a81e746
Compare
asendra
changed the title
AVQueuePlayerWrapperLegacy implementation
ceciliasaraiva
approved these changes
Nov 29, 2024
emin-grbo
approved these changes
Dec 3, 2024
asendra
force-pushed
the
alberto/remove-legacy-player-impl
branch
from
a81e746 to
c2e775d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to migrate all GenericMediaPlayer implementations to the new unified caching layer.
This will allow us to enforce a LIFO with maximum storage size quotas between all of them, and the possibility to inform of the storage usage and the ability to clear the cache as requested.
Description
Now that we are exclusively using the new
AVQueuePlayerWrapperimplementation with the improved caching, we can get rid of the legacy one in preparation for the migrate to the unified cache layer.