Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player] Unified caching (1/X): Remove AVQueuePlayerWrapperLegacy implementation #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Player] Unified caching (1/X): Remove AVQueuePlayerWrapperLegacy implementation #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c61ac
Removed legacy AVQueuePlayer implementation
asendra Nov 28, 2024
c2e775d
Uts fixes
asendra Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Sources/Player/Common/Extensions/Player+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
import Foundation

extension Player {
static func mainPlayerType(
_ featureFlagProvider: FeatureFlagProvider
) -> MainPlayerType.Type {
if featureFlagProvider.shouldUseImprovedCaching() {
AVQueuePlayerWrapper.self
} else {
AVQueuePlayerWrapperLegacy.self
}
static func mainPlayerType() -> MainPlayerType.Type {
AVQueuePlayerWrapper.self
}
}
1 change: 0 additions & 1 deletion Sources/Player/Common/FeatureFlags/FeatureFlagProvider+Standard.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ public extension FeatureFlagProvider {
static let standard = FeatureFlagProvider(
shouldUseEventProducer: { false },
isContentCachingEnabled: { true },
shouldUseImprovedCaching: { false },
shouldPauseAndPlayAroundSeek: { false },
shouldNotPerformActionAtItemEnd: { false }
)
Expand Down
3 changes: 0 additions & 3 deletions Sources/Player/Common/FeatureFlags/FeatureFlagProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
public struct FeatureFlagProvider {
public var shouldUseEventProducer: () -> Bool
public var isContentCachingEnabled: () -> Bool
public var shouldUseImprovedCaching: () -> Bool
public var shouldPauseAndPlayAroundSeek: () -> Bool
public var shouldNotPerformActionAtItemEnd: () -> Bool

public init(
shouldUseEventProducer: @escaping () -> Bool,
isContentCachingEnabled: @escaping () -> Bool,
shouldUseImprovedCaching: @escaping () -> Bool,
shouldPauseAndPlayAroundSeek: @escaping () -> Bool,
shouldNotPerformActionAtItemEnd: @escaping () -> Bool
) {
self.shouldUseEventProducer = shouldUseEventProducer
self.isContentCachingEnabled = isContentCachingEnabled
self.shouldUseImprovedCaching = shouldUseImprovedCaching
self.shouldPauseAndPlayAroundSeek = shouldPauseAndPlayAroundSeek
self.shouldNotPerformActionAtItemEnd = shouldNotPerformActionAtItemEnd
}
Expand Down
1 change: 0 additions & 1 deletion Sources/Player/Mocks/Common/FeatureFlags/FeatureFlagProvider+Mock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ public extension FeatureFlagProvider {
static let mock = FeatureFlagProvider(
shouldUseEventProducer: { true },
isContentCachingEnabled: { true },
shouldUseImprovedCaching: { false },
shouldPauseAndPlayAroundSeek: { false },
shouldNotPerformActionAtItemEnd: { false }
)
Expand Down
48 changes: 0 additions & 48 deletions Sources/Player/PlaybackEngine/Internal/AVQueuePlayer/Legacy/AVPlayerAssetLegacy.swift
View file
Open in desktop

This file was deleted.

Loading
Loading