-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid cp39-musllinux_aarch64 timeout #2434
Conversation
@maartenbreddels CI now finishes consistently within 2 hours |
according to oldest-supported-numpy deprecation notice, we can require |
Closing in favour of #2435 |
* Build using backward-compatible numpy API * Add deprecated oldest-supported-numpy
ready for review jongens @maartenbreddels @EwoutH cleanest way I can think of whilst keeping cp38 support, at least on macos and most of linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
(note I’m not an maintainer or formally involved in this project in any way)
@maartenbreddels fingerprinting is broken again. comparing the - dask==2024.8.2
+ dask==2024.9.0 |
Too bad, they were so stable before. |
looks like fingerprinting is now random (not a fingerprint anymore). will pin |
@maartenbreddels green again |
Awesome, thanks! |
Supersedes #2433, tried bumping build system to numpy v2 but that is failing (and required for python 3.13 ref scipy/oldest-supported-numpy#86)
on master there is only one failing wheel build: https://github.com/vaexio/vaex/actions/runs/10835977160/job/30068700570
due to oldest-supported-numpy selecting a version of numpy for which no wheels are available. building numpy from source under QEMU takes forever, so we're hitting the builtin github actions 6 hour timeout (which can't be increased)