Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, add python 3.13, allow numpy 2.x #2446

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Dec 18, 2024

help wanted! this is failing and I don't have time to debug.

for python 3.13 support, the build system needs to be compatible with numpy 2.1

despite buildtime needing numpy 2.x, the runtime dependency can theoretically still allow numpy 1.x (see diff).

close #2425

  • python 3.7 - 3.12 can be supported with numpy v1 build-system
  • python 3.9 - 3.13 can be supported with numpy v2 build-system

ref scipy/oldest-supported-numpy#86

@ddelange ddelange changed the title Drop python 3.9, add python 3.13, allow numpy v2 Drop python 3.9, add python 3.13, allow numpy 2.x Dec 18, 2024
@ddelange
Copy link
Contributor Author

ddelange commented Dec 19, 2024

not sure if build fails fast on the first error (probably), but apart from a bunch of notes and warnings, here's our first candidate:

      src/vaexfast.cpp:2045:63: error: cannot convert ‘PyObject*’
      {aka ‘_object*’} to ‘const PyArrayObject*’ {aka ‘const
      tagPyArrayObject_fields*’}
       2045 |                         new_array_ptr =
      (double*)PyArray_DATA(new_array);

logs_32207007014.zip

@setu4993
Copy link

setu4993 commented Jan 3, 2025

I'm guessing you meant "Drop Python 3.8" and not 3.9?

@ddelange ddelange changed the title Drop python 3.9, add python 3.13, allow numpy 2.x Drop python 3.8, add python 3.13, allow numpy 2.x Jan 3, 2025
@ddelange
Copy link
Contributor Author

ddelange commented Jan 3, 2025

Thanks, adjusted the PR title 👍

@2maz 2maz mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vaex does not work with numpy==2.0.0
2 participants