Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, add python 3.13, allow numpy 2.x #2446

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Drop python 3.8, add python 3.13, allow numpy 2.x #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- {os: windows-latest, python-version: "3.8"}
- {os: macos-latest, python-version: "3.8"}
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v2
Expand Down
6 changes: 4 additions & 2 deletions packages/vaex-core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = [
"oldest-supported-numpy; python_version=='3.8'", # deprecated ref https://github.com/scipy/oldest-supported-numpy
"numpy~=1.25; python_version>'3.8'", # numpy~=2.0 fails, backward compatible build-system as of v1.25 ref https://numpy.org/doc/2.1/dev/depending_on_numpy.html#build-time-dependency
# pythohn 3.9 supported in numpy v2.0
# python 3.13 supported as of numpy v2.1
# ref https://github.com/scipy/oldest-supported-numpy/pull/86
"numpy~=2.0",
"scikit-build",
"cmake",
"ninja"
Expand Down
12 changes: 6 additions & 6 deletions packages/vaex-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,12 @@
license = "MIT"
version = version.__version__
url = "https://www.github.com/maartenbreddels/vaex"
# TODO: after python2 supports frops, future and futures can also be dropped
setup_requires = ["numpy~=1.17"]
setup_requires = ["numpy~=2.0"] # see vaex-core pyproject.toml
install_requires_core = [
"numpy~=1.17",
"numpy>=1.19.3,<3", # 1.19.3 is the first version with 3.9 wheels
"aplus",
"tabulate>=0.8.3",
"dask!=2022.4.0,<2024.9", # fingerprinting in no longer deterministic as of 2024.9.0
"future>=0.15.2",
"pyyaml",
"six",
"cloudpickle",
Expand Down Expand Up @@ -271,13 +269,15 @@ def __str__(self):
if not use_skbuild
else [],
zip_safe=False,
python_requires=">=3.8,<3.13", # 3.13 needs numpy 2.1 support ref https://github.com/vaexio/vaex/pull/2434
# 3.9 is the oldest python version that the new numpy build system supports
# ref https://github.com/scipy/oldest-supported-numpy/pull/86
python_requires=">=3.9,<3.14",
classifiers=[
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
],
extras_require=extras_require_core,
entry_points={
Expand Down
Loading