Log proper names for POSIX signals #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
approved these changes
Jan 14, 2025
psafont
force-pushed
the
private/paus/logsig
branch
from
d32a9fb to
c16e2cb
Compare
edwintorok
reviewed
Jan 14, 2025
lindig
approved these changes
Jan 14, 2025
freddy77
reviewed
Jan 14, 2025
freddy77
reviewed
Jan 14, 2025
psafont
force-pushed
the
private/paus/logsig
branch
2 times, most recently
from
ca71749 to
7cca110
Compare
edwintorok
approved these changes
Jan 14, 2025
edwintorok
reviewed
Jan 14, 2025
psafont
force-pushed
the
private/paus/logsig
branch
from
7cca110 to
4580f04
Compare
Vincent-lau
approved these changes
Jan 15, 2025
Yes, it's completely deleted by the second commit. I'm not planning on squashing it |
The integer values that OCaml uses for signals should never be printed as they are. They can cause confusion because they don't match the C POSIX values. Change the unixext function that converts them to string to stop building a list and finding a value in the list to instead use pattern-matching. Also added some more values that got introduced in OCaml 4.03, and return a more compact value for unknown signals, following the same format as Fmt.Dump.signal Signed-off-by: Pau Ruiz Safont <[email protected]>
When signals are are written to logs, the POSIX name should be used to minimize confusion. It makes sense that the function that does this is in the logging library instead of the unix one, as most users will be already be using the logging library, but not all the unix one. Moving it there also allows for a more ergonomic usage with the logging functions. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/logsig
branch
from
4580f04 to
c0fbb69
Compare
lindig
reviewed
Jan 16, 2025
| @@ -353,4 +353,8 @@ functor | |||
| with e -> log_backtrace_internal ~level:Syslog.Debug ~msg:"debug" e () | |||
| end | |||
|
|
|||
| module Pp = struct let mtime_span () = Fmt.str "%a" Mtime.Span.pp end | |||
| module Pp = struct | |||
There was a problem hiding this comment.
I would have liked PP or Pretty better - but it already exists.
|
Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integer values that OCaml uses for signals should never be printed as integers. They can cause confusion because they don't match the C POSIX values.
Change the unixext function that converts them to string to stop building a list and finding a value in the list to instead use pattern-matching. Also added some more values that got introduced in OCaml 4.03, and return a more compact value for unknown signals, following the same format as Fmt.Dump.signal.
Typically, engineers see signal -11 and assume it's SIGSEGV, when it's SIGTERM.
Fixes #6225