Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix clip_media source for review track. #1056

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Editorial: Fix clip_media source for review track. #1056

merged 4 commits into from
Jan 8, 2025

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

This PR fixes the issue when Hiero does not publish review product properly.
Ensure that the following use-cases works properly:

  • review disabled
  • [Clip's media]
  • Track: current track
  • Track: another track

Testing notes:

  1. Setup a multi-tracks timeline in Hiero
  2. Publish a timeline with review source set as clip_media and another one as track:XX
  3. Ensure review media works for each scenarios

@robin-ynput robin-ynput self-assigned this Dec 16, 2024
@ynbot ynbot added size/XS type: bug Something isn't working labels Dec 16, 2024
@robin-ynput robin-ynput marked this pull request as ready for review December 16, 2024 09:41
iLLiCiTiT
iLLiCiTiT approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes do make sense but @jakubjezek001 please confirm.

@robin-ynput
Copy link
Contributor Author

robin-ynput commented Dec 16, 2024 •
edited
Loading

Changes do make sense but @jakubjezek001 please confirm.

To detail a bit the initial bug, when input source for review was set to a track the logic was adding 2 representations:

  • the OTIO based review from the track (correct)
  • the clip_media source media (wrong)

This was causing an issue when integrating the review (duplicated representation destination).

jakubjezek001
jakubjezek001 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@robin-ynput robin-ynput merged commit bee5c31 into develop Jan 8, 2025
1 check passed
@robin-ynput robin-ynput deleted the bugfix/fix_clip_media_review branch January 8, 2025 15:24
@robin-ynput robin-ynput mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@robin-ynput robin-ynput

Labels
size/XS type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robin-ynput @jakubjezek001 @iLLiCiTiT @ynbot