Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new z16 partition power metrics #462

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Added new z16 partition power metrics #462

merged 1 commit into from
Feb 24, 2024

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Feb 21, 2024 •
edited
Loading

For details, see the commit message.

Particular review points:

  • Exported names of the new metrics
  • Exported descriptions of the new metrics

End2end tests:

  • Ran the exporter against the HMC of A224 to verify the new metrics are exported for A224 but not for T224 and M224M.
  • Did not run the exporter against a z16 in classic mode

@andy-maier andy-maier self-assigned this Feb 21, 2024
@andy-maier andy-maier added this to the 1.6.0 milestone Feb 21, 2024
@coveralls
Copy link

coveralls commented Feb 21, 2024 •
edited
Loading

Coverage Status

coverage: 35.751%. remained the same
when pulling aa46ec1 on andy/add-z16-power-metrics
into 5f51d98 on master.

@andy-maier andy-maier force-pushed the andy/add-z16-power-metrics branch from 35c7883 to 2871416 Compare February 21, 2024 18:30
@andy-maier andy-maier linked an issue Feb 21, 2024 that may be closed by this pull request
Support for new power metrics added in 2.16 GA 1.5 #448
Closed
@andy-maier andy-maier changed the title Added new z16 power metrics in metric group 'zcpc-environmentals-and-power' Added new z16 power metrics Feb 21, 2024
@andy-maier andy-maier force-pushed the andy/add-z16-power-metrics branch from 2871416 to 7b21ea4 Compare February 21, 2024 18:31
@andy-maier andy-maier changed the title Added new z16 power metrics Added new z16 partition power metrics Feb 21, 2024
@andy-maier andy-maier force-pushed the andy/add-z16-power-metrics branch 8 times, most recently from f8e77ce to 4b32f4d Compare February 22, 2024 13:39
@andy-maier
Added new z16 partition power metrics
aa46ec1 
Details:

* Added support for the new power consumption metrics in z16 (issue #448):

  In metric group 'zcpc-environmentals-and-power':

  - 'total_partition_power_watt' - Total power consumption of all partitions
  - 'total_infrastructure_power_watt' - Total power consumption of
    infrastructure components
  - 'total_unassigned_power_watt' - Total power consumption of unassigned
    components

  In metric group 'logical-partition-usage':

  - 'partition_power_watt' - Power consumption of the partition

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier force-pushed the andy/add-z16-power-metrics branch from 4b32f4d to aa46ec1 Compare February 24, 2024 14:38
@andy-maier andy-maier merged commit f9f1362 into master Feb 24, 2024
17 checks passed
@andy-maier andy-maier deleted the andy/add-z16-power-metrics branch February 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilak11 anilak11 anilak11 approved these changes

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Support for new power metrics added in 2.16 GA 1.5
3 participants
@andy-maier @coveralls @anilak11