fix: [spearbit-72] cache dependencies.length earlier #40
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
01-07-fix_spearbit-86_store_sessionKeyData.contractAccessControlType_in_a_local_variable
branch
from
17145da to
f987ff1
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-72_cache_dependencies.length_earlier
branch
from
a72e6ad to
6bef45e
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-86_store_sessionKeyData.contractAccessControlType_in_a_local_variable
branch
from
f987ff1 to
9c6d531
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-72_cache_dependencies.length_earlier
branch
from
6bef45e to
04609fa
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-86_store_sessionKeyData.contractAccessControlType_in_a_local_variable
branch
from
9c6d531 to
ae27491
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-72_cache_dependencies.length_earlier
branch
from
04609fa to
487ec2d
Compare
| @@ -350,11 +350,11 @@ abstract contract PluginManagerInternals is IPluginManager, AccountStorageV1 { | |||
| } | |||
|
|
|||
| // Check that the dependencies match the manifest. | |||
| if (dependencies.length != manifest.dependencyInterfaceIds.length) { | |||
| uint256 length = dependencies.length; | |||
| if (length != manifest.dependencyInterfaceIds.length) { | |||
| revert InvalidDependenciesProvided(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: can we get rid of the empty line here to indicate that the following for loop is a continued usage of length and logic on dependencies?
fangting-alchemy
approved these changes
Jan 8, 2024
jaypaik
force-pushed
the
01-07-fix_spearbit-86_store_sessionKeyData.contractAccessControlType_in_a_local_variable
branch
from
ae27491 to
2a05949
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-72_cache_dependencies.length_earlier
branch
from
487ec2d to
8b20450
Compare
Base automatically changed from
01-07-fix_spearbit-86_store_sessionKeyData.contractAccessControlType_in_a_local_variable
to
audit-2023-11-20
January 8, 2024 22:27
jaypaik
deleted the
01-07-fix_spearbit-72_cache_dependencies.length_earlier
branch
jaypaik
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size before: 24.274
Size after: 24.273
https://github.com/spearbit-audits/alchemy-nov-review/issues/72