feat: add table column setting to Environments page #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
6 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
This was referenced Oct 29, 2024
agatha197
force-pushed
the
feature/add-AliasedBaseImageName
branch
from
cf42f0e to
09bf733
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
2b8056f to
1dbe343
Compare
agatha197
force-pushed
the
feature/add-AliasedBaseImageName
branch
from
09bf733 to
a98a494
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
2 times, most recently
from
d8c4775 to
412bd1c
Compare
agatha197
changed the base branch from
feature/add-AliasedBaseImageName
to
feature/replace-name-with-namespace
This was referenced Oct 31, 2024
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
01fc2fd to
047ba54
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
412bd1c to
dab23a0
Compare
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
047ba54 to
6695815
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
dab23a0 to
0011774
Compare
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
6695815 to
cbb0e50
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
0011774 to
fde8595
Compare
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
cbb0e50 to
e1139c6
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
fde8595 to
ede0978
Compare
6 tasks
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
2346c51 to
55bcf7e
Compare
agatha197
changed the base branch from
feature/replace-name-with-namespace
to
feat/add-getImageFullName-test-file
agatha197
force-pushed
the
feat/add-getImageFullName-test-file
branch
from
b8a0b37 to
a980e40
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
2 times, most recently
from
70a122e to
58212b1
Compare
agatha197
changed the base branch from
feat/add-getImageFullName-test-file
to
feature/replace-name-with-namespace
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
92cdd3e to
143e45d
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
58212b1 to
c55d292
Compare
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
143e45d to
2ba59aa
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
c55d292 to
23f8a66
Compare
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
from
2ba59aa to
7dbc971
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
23f8a66 to
232381e
Compare
2 tasks
agatha197
force-pushed
the
feature/replace-name-with-namespace
branch
2 times, most recently
from
408ee75 to
d7d64c4
Compare
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
232381e to
7662c65
Compare
Merge activity
|
agatha197
changed the base branch from
feature/replace-name-with-namespace
to
graphite-base/2789
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
7662c65 to
53af4e3
Compare
**Changes:** This PR enhances the ImageList component in the following ways: 1. Adds a new TableColumnsSettingModal component for customizing visible columns. 2. Implements column visibility persistence using local storage. 3. Introduces a settings button to open the column customization modal. 4. Improves the digest column rendering with ellipsis and tooltip for better readability. **How to test:** > endpoint: 10.100.64.15 1. Checkout core branch to `topic/10-22-feature_add_info_field_to_gql_image_schema` 2. Visit Environments page. 3. Check the setting icon at the bottom of the table. **Rationale:** These changes provide users with more control over the information displayed in the image list, improving the overall user experience and allowing for a more personalized view of the data. **Effects:** - Users can now customize which columns are visible in the image list. - Column visibility preferences are persisted across sessions. - Long digest values are now truncated with an ellipsis and full text available via tooltip. **Screenshots:**  **Checklist:** - [ ] Documentation: Update user guide to explain the new column customization feature - [ ] Test case: Verify that column visibility settings are correctly saved and applied - [ ] Test case: Ensure the digest column truncation and tooltip work as expected
agatha197
force-pushed
the
feature/add-table-column-setting-to-environment-page
branch
from
53af4e3 to
813b937
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.92% (-0% 🔻) |
349/7096 |
| 🔴 | Branches | 4.54% (-0% 🔻) |
219/4828 |
| 🔴 | Functions | 2.85% (-0% 🔻) |
67/2350 |
| 🔴 | Lines | 4.81% (-0% 🔻) |
334/6942 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 813b937
graphite-app
bot
deleted the
feature/add-table-column-setting-to-environment-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the ImageList component in the following ways:
How to test:
topic/10-22-feature_add_info_field_to_gql_image_schemaRationale:
These changes provide users with more control over the information displayed in the image list, improving the overall user experience and allowing for a more personalized view of the data.
Effects:
Screenshots:
Checklist: