-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace name with namespace #2787
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
b5b801e
to
e29820c
Compare
22364bb
to
01fc2fd
Compare
e29820c
to
7cc7dfa
Compare
01fc2fd
to
047ba54
Compare
7cc7dfa
to
8aa4dfc
Compare
047ba54
to
6695815
Compare
8aa4dfc
to
b75514d
Compare
6695815
to
cbb0e50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine, but I left some small comments :)
b75514d
to
6c80e2e
Compare
cbb0e50
to
e1139c6
Compare
This is a trailing dot of GraphQL version directive. I fixed it and pushed. |
8b7d2a6
to
483a427
Compare
fbed260
to
92cdd3e
Compare
483a427
to
b95b56b
Compare
92cdd3e
to
143e45d
Compare
b95b56b
to
07ac58f
Compare
143e45d
to
2ba59aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
07ac58f
to
1aaa31b
Compare
2ba59aa
to
7dbc971
Compare
1aaa31b
to
b0d7ea2
Compare
7dbc971
to
408ee75
Compare
408ee75
to
d7d64c4
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.92% | 349/7089 |
🔴 | Branches | 4.54% | 219/4824 |
🔴 | Functions | 2.86% | 67/2346 |
🔴 | Lines | 4.82% | 334/6935 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 299ae73
Merge activity
|
# Support for Extended Image Info This PR introduces support for the extended image info feature, which affects how image namespaces are handled and displayed throughout the application. **Changes:** - Added a `supportExtendedImageInfo` flag based on the backend client's capabilities - Updated image queries to use `namespace` instead of `name` when extended image info is supported - Modified image full name generation to prioritize `namespace` over `name` - Adjusted environment selection logic to use `namespace` when available - Updated table columns in MyEnvironmentPage to display and sort by `namespace` when supported **Rationale:** These changes allow the application to work with both the old and new image information structures, providing a smooth transition as the backend evolves. **Effects:** - Users will see more accurate namespace information when using a backend that supports extended image info - Developers should be aware of the `supportExtendedImageInfo` flag when working with image-related components **How to test:** 1. Checkout core branch to `topic/10-22-feature_add_info_field_to_gql_image_schema` 2. Check the environments, my environments, session page which are using `namespace` (before lablup/backend.ai#2939, it was `name`.) of `images` query. **Screenshots:** In #2785, the part of the full image path field had `undefined`. But it has some value now. ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/a2553afe-d555-40b3-bc4e-bb1b79fa4b87.png) **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: 24.09.1 - [x] Specific setting for review - [x] Minimum requirements to check during review: - Verify that image namespaces are correctly displayed and used when extended image info is supported - Ensure backwards compatibility with older backend versions - [ ] Test case(s) to demonstrate the difference of before/after
d7d64c4
to
299ae73
Compare
Support for Extended Image Info
This PR introduces support for the extended image info feature, which affects how image namespaces are handled and displayed throughout the application.
Changes:
supportExtendedImageInfo
flag based on the backend client's capabilitiesnamespace
instead ofname
when extended image info is supportednamespace
overname
namespace
when availablenamespace
when supportedRationale:
These changes allow the application to work with both the old and new image information structures, providing a smooth transition as the backend evolves.
Effects:
supportExtendedImageInfo
flag when working with image-related componentsHow to test:
topic/10-22-feature_add_info_field_to_gql_image_schema
namespace
(before feat: Add info fields to GQL image schema backend.ai#2939, it wasname
.) ofimages
query.Screenshots:
In #2785, the part of the full image path field had
undefined
. But it has some value now.Checklist: