refactor: MyEnvironmentPage into two components
#2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 31, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
3 tasks
5 tasks
agatha197
force-pushed
the
feature/add-AliasedBaseImageName
branch
from
a26bc16 to
5680e71
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
e8e082a to
43f8c1e
Compare
agatha197
force-pushed
the
feature/add-AliasedBaseImageName
branch
from
5680e71 to
beb3763
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
43f8c1e to
2dce71b
Compare
agatha197
force-pushed
the
feature/add-AliasedBaseImageName
branch
from
beb3763 to
b1d47a2
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
2dce71b to
1c211d1
Compare
agatha197
changed the base branch from
feature/add-AliasedBaseImageName
to
feature/add-AliasedImageDoubleTags
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
faefb29 to
9c69555
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
1c211d1 to
ae05d34
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
9c69555 to
b81207d
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
ae05d34 to
f2eee29
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
b81207d to
13757c9
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
f2eee29 to
5e111e7
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
13757c9 to
2273745
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
5e111e7 to
feed2ae
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
ebe8809 to
5c0cbbe
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
c2cf13b to
94ecae3
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
5c0cbbe to
e85e377
Compare
6 tasks
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
94ecae3 to
073c949
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
e85e377 to
05303a6
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
073c949 to
e973a5f
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
05303a6 to
c0d1d04
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
e973a5f to
9db3957
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
c0d1d04 to
22293b5
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
9db3957 to
ab5b02c
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
22293b5 to
7bdbead
Compare
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
ab5b02c to
00b08c5
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
7bdbead to
c1490e8
Compare
2 tasks
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
00b08c5 to
85ca66e
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
c1490e8 to
e42e855
Compare
Merge activity
|
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
85ca66e to
02a471b
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
e42e855 to
4db0daa
Compare
## What to check I just separated MyEnvironmentPage into two components, moving the Card component to `MyEnvironmentPage`. Thus, you don't need to check the detailed logic of CustomizedImageList. To see the improved codes for CustomizedImageList, please refer #2795. --- **Changes:** Refactored the customized image list functionality by: - Extracting image list logic from MyEnvironmentPage into a new CustomizedImageList component - Simplified MyEnvironmentPage to use tabs and the new component - Added proper type definitions and GraphQL query/mutation handling - Implemented sorting, filtering, and column customization features - Added copy functionality for image names - Included delete confirmation dialogs with proper error handling **Checklist:** - [ ] Documentation - [x] Minimum required manager version: 24.09.1 (based on GraphQL schema changes) - [ ] Test cases needed: - Column customization persistence - Image deletion workflow - Sorting functionality across all columns - Copy image name feature The changes improve code organization and maintainability while preserving all existing functionality for managing customized container images.
agatha197
force-pushed
the
feature/add-AliasedImageDoubleTags
branch
from
02a471b to
3eb62b8
Compare
agatha197
force-pushed
the
reactor/MyEnvironmentPage-into-two-components
branch
from
4db0daa to
b61f9b6
Compare
graphite-app
bot
deleted the
reactor/MyEnvironmentPage-into-two-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to check
I just separated MyEnvironmentPage into two components, moving the Card component to
MyEnvironmentPage. Thus, you don't need to check the detailed logic of CustomizedImageList. To see the improved codes for CustomizedImageList, please refer #2795.Changes:
Refactored the customized image list functionality by:
Checklist:
The changes improve code organization and maintainability while preserving all existing functionality for managing customized container images.